Re: [PATCH v5 6/8] drm/panel: Add ilitek ili9341 panel driver

[Linus Walleij]

On Mon, May 25, 2020 at 5:46 AM <dillon.minfei@xxxxxxxxx> wrote:

> From: dillon min <dillon.minfei@xxxxxxxxx>
>
>     This driver combine tiny/ili9341.c mipi_dbi_interface driver
>     with mipi_dpi_interface driver, can support ili9341 with serial
>     mode or parallel rgb interface mode by register configuration.
>
> Changes since V3:
>
>     accoding to Linus Walleij's suggestion.
>     1 add more comments to driver.
>     2 reduce magic number usage in the driver.
>     3 move panel configuration from common place to system configuration.
>     4 reuse MIPI_DCS_* as more as possible.
>
> Signed-off-by: dillon min <dillon.minfei@xxxxxxxxx>

This looks good to me!
Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Yours,
Linus Walleij