Re: [PATCH v5 2/3] dt-bindings: arm: actions: Document Caninos Loucos Labrador

[Matheus Castello]

Hi Andreas,

Em 5/25/20 7:41 AM, Andreas FÃrber escreveu:
> Hi,
>
> Am 25.05.20 um 03:30 schrieb Matheus Castello:
> > Update the documentation to add the Caninos Loucos Labrador. Labrador
> > project consists of a computer on module based on the Actions Semi S500
> > processor and the Labrador base board.
> >
> > Signed-off-by: Matheus Castello <matheus@xxxxxxxxxxxxxxx>
> > Acked-by: Rob Herring <robh@xxxxxxxxxx>
> > ---
> > Â Documentation/devicetree/bindings/arm/actions.yaml | 5 +++++
> > Â 1 file changed, 5 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/arm/actions.yaml 
> > b/Documentation/devicetree/bindings/arm/actions.yaml
> > index ace3fdaa8396..2187e1c5bc73 100644
> > --- a/Documentation/devicetree/bindings/arm/actions.yaml
> > +++ b/Documentation/devicetree/bindings/arm/actions.yaml
> > @@ -19,6 +19,11 @@ properties:
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ - allo,sparky # Allo.com Sparky
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ - cubietech,cubieboard6 # Cubietech CubieBoard6
> > ÂÂÂÂÂÂÂÂÂÂÂ - const: actions,s500
> > +ÂÂÂÂÂ - items:
> > +ÂÂÂÂÂÂÂÂÂ - enum:
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂ - caninos,labrador-v2 # Labrador Core v2
> > +ÂÂÂÂÂÂÂÂÂÂÂÂÂ - caninos,labrador-base-m # Labrador Base Board M v1
>
> This enum still strikes me as wrong, it means either-or. (Was planning 
> to look into it myself, but no time yet...) caninos,labrador-v2 should 
> be a const one level down: board, SoM, SoC from most specific to most 
> generic. Compare Guitar below.

I got it, I agree make sense, I will send the v6.

> > +ÂÂÂÂÂÂÂÂÂ - const: actions,s500
> > ÂÂÂÂÂÂÂ - items:
> > ÂÂÂÂÂÂÂÂÂÂÂ - enum:
> > ÂÂÂÂÂÂÂÂÂÂÂÂÂÂÂ - lemaker,guitar-bb-rev-b # LeMaker Guitar Base Board 
> > rev. B
>
> Regards,
> Andreas

Best Regards,
Matheus Castello