Re: [PATCH] RDMA/core: fix missing release in add_port.
From: Jason Gunthorpe
Date: Mon May 25 2020 - 09:03:45 EST
On Mon, May 25, 2020 at 01:06:56AM -0500, wu000273@xxxxxxx wrote:
> From: Qiushi Wu <wu000273@xxxxxxx>
> In function add_port(), pointer p is not released in error paths.
> Fix this issue by adding a kfree(p) into the end of error path.
> Signed-off-by: Qiushi Wu <wu000273@xxxxxxx>
> drivers/infiniband/core/sysfs.c | 1 +
> 1 file changed, 1 insertion(+)
> diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c
> index 087682e6969e..04a003378dfc 100644
> +++ b/drivers/infiniband/core/sysfs.c
> @@ -1202,6 +1202,7 @@ static int add_port(struct ib_core_device *coredev, int port_num)
> + kfree(p);
> return ret;
Er, no, kobject_put does the kfree
There is a bug here, it is calling kfree() after kobject_init_and_add
fails, which is wrong, it should be goto err_put