Re: [PATCH v3 07/19] mm: memcg/slab: allocate obj_cgroups for non-root slab pages

From: Vlastimil Babka
Date: Mon May 25 2020 - 10:46:50 EST


On 4/22/20 10:46 PM, Roman Gushchin wrote:
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -1370,7 +1370,8 @@ static struct page *kmem_getpages(struct kmem_cache *cachep, gfp_t flags,
> return NULL;
> }
>
> - if (charge_slab_page(page, flags, cachep->gfporder, cachep)) {
> + if (charge_slab_page(page, flags, cachep->gfporder, cachep,
> + cachep->num)) {
> __free_pages(page, cachep->gfporder);
> return NULL;
> }

Hmm noticed only when looking at later patch, this hunks adds a parameter that
the function doesn't take, so it doesn't compile.