Re: [PATCH v2] media: coda: Fix runtime PM imbalance in coda_probe()
From: Markus Elfring
Date: Mon May 25 2020 - 11:15:46 EST
> When coda_firmware_request() returns an error code,
> a pairing runtime PM usage counter decrement is needed
> to keep the counter balanced.
* I suggest to add an imperative wording.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=9cb1fd0efd195590b828b9b865421ad345a4a145#n151
* Would you like to add the tag âFixesâ to the commit message?
> Changelog:
I propose to omit this line.
> ---
> drivers/media/platform/coda/coda-common.c | 2 ++
I find it nicer to replace the triple dashes before this diffstat
by a blank line.
Regards,
Markus