Re: [PATCH v2 1/4] pwm: jz4740: Drop dependency on MACH_INGENIC

[Uwe Kleine-König]

Hello,

On Mon, May 25, 2020 at 02:57:19PM +0200, Paul Cercueil wrote:
> Depending on MACH_INGENIC prevent us from creating a generic kernel that
> works on more than one MIPS board. Instead, we just depend on MIPS being
> set.
> 
> Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>

Nitpick: Your S-o-B should come last. So if you added my Ack the
resulting commit then has (after being picked up by a maintainer):

 .	Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
 .	Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
 .	Signed-off-by: Peter Maintainer <...>

(quoted to not let patchwork pick up tags) while when the Ack is added
by the maintainer the result is

 .	Signed-off-by: Paul Cercueil <paul@xxxxxxxxxxxxxxx>
 .	Acked-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx>
 .	Signed-off-by: Peter Maintainer <...>

. So the order tells the reader who added a tag.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |