Re: [PATCH v2 16/18] nitro_enclaves: Add sample for ioctl interface usage

[Paraschiv, Andra-Irina]

On 22/05/2020 10:11, Greg KH wrote:
> On Fri, May 22, 2020 at 09:29:44AM +0300, Andra Paraschiv wrote:
> > Signed-off-by: Alexandru Vasile <lexnv@xxxxxxxxxx>
> > Signed-off-by: Andra Paraschiv <andraprs@xxxxxxxxxx>
> No changelog?

I included the changelog in v3.

> > ---
> >   samples/nitro_enclaves/.gitignore             |   2 +
> >   samples/nitro_enclaves/Makefile               |  28 +
> >   .../include/linux/nitro_enclaves.h            |  23 +
> >   .../include/uapi/linux/nitro_enclaves.h       |  77 +++
> Why are you not using the uapi files from the kernel itself?  How are
> you going to keep these in sync?

Yeah, the uapi files should be used, I just removed the include folder 
from here.

Thank you.

Andra



Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.