Re: [PATCH v2 1/2] crypto: virtio: Fix src/dst scatterlist calculation in __virtio_crypto_skcipher_do_req()

[Markus Elfring]

> Fix it by sg_next() on calculation of src/dst scatterlist.

Wording adjustment:
â by calling the function âsg_nextâ â


â
> +++ b/drivers/crypto/virtio/virtio_crypto_algs.c
> @@ -350,13 +350,18 @@ __virtio_crypto_skcipher_do_req(struct virtio_crypto_sym_request *vc_sym_req,
â
>  	src_nents = sg_nents_for_len(req->src, req->cryptlen);
> +	if (src_nents < 0) {
> +		pr_err("Invalid number of src SG.\n");
> +		return src_nents;
> +	}
> +
>  	dst_nents = sg_nents(req->dst);
â

I suggest to move the addition of such input parameter validation
to a separate update step.

Regards,
Markus