Re: [PATCH] serial: 8250: probe all 16550A variants by default

From: Maxim Kochetkov
Date: Tue May 26 2020 - 03:05:47 EST


This change breaks all my devices: OMAP-L138 (davinci based), LS1021A, T1040, Marvell (kirkwood2 based). Only enabling VARIANTS on all my devices fix the issue.

25.05.2020 20:28, Josh Triplett wrote:
On Mon, May 25, 2020 at 04:02:38PM +0300, Vladimir Oltean wrote:
On NXP T1040, the UART is typically detected as 16550A_FSL64. After said
patch, it gets detected as plain 16550A and the Linux console is
completely garbled and missing characters.
Interesting that there's*new* powerpc hardware that needs these
variants. I based the patch on the fact that, on x86 at least, hardware
using these variants hasn't been made for a long time.