Re: Re: [PATCH] scsi: ufs: Fix runtime PM imbalance on error
From: dinghao . liu
Date: Tue May 26 2020 - 06:13:04 EST
> Hi,
>
> On 22/05/20 10:23 am, Dinghao Liu wrote:
> > When devm_clk_get() returns an error code, a pairing
> > runtime PM usage counter decrement is needed to keep
> > the counter balanced.
> >
> > Signed-off-by: Dinghao Liu <dinghao.liu@xxxxxxxxxx>
> > ---
>
> Thanks for the patch! But this fix is incomplete, I have posted
> a more comprehensive fix at [1].. Please take a look!
You are right, we should call pm_runtime_disable() on error, too.
Thank your for your reminder!
Regards,
Dinghao