Re: [PATCH v5 6/8] drm/panel: Add ilitek ili9341 panel driver

From: Noralf TrÃnnes
Date: Tue May 26 2020 - 06:38:11 EST




Den 26.05.2020 11.08, skrev dillon min:
> Hi Andy,
>
> Thanks for input.
>
> On Tue, May 26, 2020 at 3:46 PM Andy Shevchenko
> <andy.shevchenko@xxxxxxxxx> wrote:
>>
>> On Mon, May 25, 2020 at 6:46 AM <dillon.minfei@xxxxxxxxx> wrote:
>>>
>>> From: dillon min <dillon.minfei@xxxxxxxxx>
>>>
>>> This driver combine tiny/ili9341.c mipi_dbi_interface driver
>>> with mipi_dpi_interface driver, can support ili9341 with serial
>>> mode or parallel rgb interface mode by register configuration.
>>
>> Noralf told once that this driver should be unified with mi0283qt.c.
>>
>> So, what should we do here?
>>
>> --
>> With Best Regards,
>> Andy Shevchenko
>
> from sam's suggestion, we can't setup two drivers to support one panel
> in the tree. so, i copy the mipi dbi part from tiny/ili9341.c. to this driver
> from register settings and dts binding is keep the same to tiny/ili9341.c.
>
> so, in my opinion if tiny/ili9341.c is unified with mi0283qt.c, this
> driver should be
> too.
>

There's a discussion about MIPI DBI panels here:

MIPI DSI, DBI, and tinydrm drivers
https://lists.freedesktop.org/archives/dri-devel/2020-May/267031.html

Noralf.

> thanks.
>
> best regards,
>
> Dillon,
>