Re: [PATCH v3 02/18] nitro_enclaves: Define the PCI device interface

[Paraschiv, Andra-Irina]

On 26/05/2020 09:44, Greg KH wrote:
> On Tue, May 26, 2020 at 01:13:18AM +0300, Andra Paraschiv wrote:
> > +struct enclave_get_slot_req {
> > +	/* Context ID (CID) for the enclave vsock device. */
> > +	u64 enclave_cid;
> > +} __attribute__ ((__packed__));
> Can you really "pack" a single member structure?
>
> Anyway, we have better ways to specify this instead of the "raw"
> __attribute__ option.  But first see if you really need any of these, at
> first glance, I do not think you do at all, and they can all be removed.

There are a couple of data structures with more than one member and 
multiple field sizes. And for the ones that are not, gathered as 
feedback from previous rounds of review that should consider adding a 
"flags" field in there for further extensibility.

I can modify to have "__packed" instead of the attribute callout.

Thanks,
Andra



Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in Romania. Registration number J22/2621/2005.