Re: [net-next RFC v3 2/6] net: marvell: prestera: Add PCI interface support

[Jakub Kicinski]

On Tue, 26 May 2020 20:12:58 +0300 Vadym Kochan wrote:
> Add PCI interface driver for Prestera Switch ASICs family devices, which
> provides:
> 
>     - Firmware loading mechanism
>     - Requests & events handling to/from the firmware
>     - Access to the firmware on the bus level
> 
> The firmware has to be loaded each time device is reset. The driver is
> loading it from:
> 
>     /lib/firmware/marvell/prestera_fw-v{MAJOR}.{MINOR}.img
> 
> The full firmware image version is located within internal header and
> consists of 3 numbers - MAJOR.MINOR.PATCH. Additionally, driver has
> hard-coded minimum supported firmware version which it can work with:
> 
>     MAJOR - reflects the support on ABI level between driver and loaded
>             firmware, this number should be the same for driver and loaded
>             firmware.
> 
>     MINOR - this is the minimum supported version between driver and the
>             firmware.
> 
>     PATCH - indicates only fixes, firmware ABI is not changed.
> 
> Firmware image file name contains only MAJOR and MINOR numbers to make
> driver be compatible with any PATCH version.
> 
> Signed-off-by: Oleksandr Mazur <oleksandr.mazur@xxxxxxxxxxx>
> Signed-off-by: Vadym Kochan <vadym.kochan@xxxxxxxxxxx>

W=1 gives me:

drivers/net/ethernet/marvell/prestera/prestera_pci.c: In function prestera_fw_rev_check:
drivers/net/ethernet/marvell/prestera/prestera_pci.c:590:15: warning: comparison is always true due to limited range of data type [-Wtype-limits]
  590 |      rev->min >= PRESTERA_SUPP_FW_MIN_VER) {
      |               ^~