Re: [PATCH v3 5/5] PCI/AER: Replace pcie_aer_get_firmware_first() with pcie_aer_is_native()

From: kbuild test robot
Date: Tue May 26 2020 - 15:23:14 EST


Hi,

I love your patch! Yet something to improve:

[auto build test ERROR on pci/next]
[also build test ERROR on next-20200526]
[cannot apply to v5.7-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/sathyanarayanan-kuppuswamy-linux-intel-com/Remove-AER-HEST-table-parser/20200525-053721
base: https://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git next
config: arm-gemini_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=arm

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>, old ones prefixed by <<):

In file included from drivers/pci/pci-driver.c:7:
include/linux/pci.h:1554:31: error: 'false' redeclared as different kind of symbol
1554 | #define pcie_ports_dpc_native false
| ^~~~~
drivers/pci/pcie/portdrv.h:28:13: note: in expansion of macro 'pcie_ports_dpc_native'
28 | extern bool pcie_ports_dpc_native;
| ^~~~~~~~~~~~~~~~~~~~~
In file included from include/uapi/linux/posix_types.h:5,
from include/uapi/linux/types.h:14,
from include/linux/types.h:6,
from include/linux/mod_devicetable.h:12,
from include/linux/pci.h:27,
from drivers/pci/pci-driver.c:7:
include/linux/stddef.h:11:2: note: previous definition of 'false' was here
11 | false = 0,
| ^~~~~
In file included from drivers/pci/pci-driver.c:22:
>> drivers/pci/pcie/portdrv.h:35:7: error: expected ';' before 'inline'
35 | statuc inline int pcie_aer_is_native(struct pci_dev *dev) { return 0; }
| ^
| ;

vim +35 drivers/pci/pcie/portdrv.h

29
30 #ifdef CONFIG_PCIEAER
31 int pcie_aer_init(void);
32 int pcie_aer_is_native(struct pci_dev *dev);
33 #else
34 static inline int pcie_aer_init(void) { return 0; }
> 35 statuc inline int pcie_aer_is_native(struct pci_dev *dev) { return 0; }
36 #endif
37

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip