Re: [PATCH 1/1] dt-bindings: MIPS: Document Ingenic SoCs binding.

[Zhou Yanjie]

Hi Paul,

å 2020/5/27 äå3:10, Paul Cercueil åé:
> Hi Zhou,
>
> Le mer. 27 mai 2020 Ã 1:07, åçæ (Zhou Yanjie) 
> <zhouyanjie@xxxxxxxxxxxxxx> a Ãcrit :
> > Document the available properties for the SoC root node and the
> > CPU nodes of the devicetree for the Ingenic XBurst SoCs.
> >
> > Tested-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
> > Tested-by: Paul Boddie <paul@xxxxxxxxxxxxx>
> > Signed-off-by: åçæ (Zhou Yanjie) <zhouyanjie@xxxxxxxxxxxxxx>
> > ---
> > Â.../bindings/mips/ingenic/ingenic,cpu.yamlÂÂÂÂÂÂÂÂ | 57 
> > ++++++++++++++++++++++
> > Â1 file changed, 57 insertions(+)
> > Âcreate mode 100644 
> > Documentation/devicetree/bindings/mips/ingenic/ingenic,cpu.yaml
> >
> > diff --git 
> > a/Documentation/devicetree/bindings/mips/ingenic/ingenic,cpu.yaml 
> > b/Documentation/devicetree/bindings/mips/ingenic/ingenic,cpu.yaml
> > new file mode 100644
> > index 000000000000..afb02071a756
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mips/ingenic/ingenic,cpu.yaml
> > @@ -0,0 +1,57 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mips/ingenic/ingenic,cpu.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Bindings for Ingenic XBurst family CPUs
> > +
> > +maintainers:
> > +Â - åçæ (Zhou Yanjie) <zhouyanjie@xxxxxxxxxxxxxx>
> > +
> > +description:
> > +Â Ingenic XBurst family CPUs shall have the following properties.
> > +
> > +properties:
> > +Â compatible:
> > +ÂÂÂ oneOf:
> > +
> > +ÂÂÂÂÂ - description: Ingenic XBurstÂ1 CPU Cores
> > +ÂÂÂÂÂÂÂ items:
>
> Strip the 'items', put the enum directly.

Sure, I'll drop it in the next version.


> > +ÂÂÂÂÂÂÂÂÂ enum:
> > +ÂÂÂÂÂÂÂÂÂÂÂ - ingenic,xburst-mxu1.0
> > +ÂÂÂÂÂÂÂÂÂÂÂ - ingenic,xburst-fpu1.0-mxu1.1
> > +ÂÂÂÂÂÂÂÂÂÂÂ - ingenic,xburst-fpu2.0-mxu2.0
> > +
> > +ÂÂÂÂÂ - description: Ingenic XBurstÂ2 CPU Cores
> > +ÂÂÂÂÂÂÂ items:
>
> Same here.

Sure.


> > +ÂÂÂÂÂÂÂÂÂ enum:
> > +ÂÂÂÂÂÂÂÂÂÂÂ - ingenic,xburst2-fpu2.1-mxu2.1-smt
> > +
> > +Â reg:
> > +ÂÂÂ maxItems: 1
> > +
> > +required:
> > +Â - device_type
> > +Â - compatible
> > +Â - reg
>
> device_type is not in the list of your properties.
>
> Also, I think you need a clock in there.

Sure, I will add it.


Thanks and best regards!


> -Paul
>
> > +
> > +examples:
> > +Â - |
> > +ÂÂÂ cpus {
> > +ÂÂÂÂÂÂÂ #address-cells = <1>;
> > +ÂÂÂÂÂÂÂ #size-cells = <0>;
> > +
> > +ÂÂÂÂÂÂÂ cpu0: cpu@0 {
> > +ÂÂÂÂÂÂÂÂÂÂÂ device_type = "cpu";
> > +ÂÂÂÂÂÂÂÂÂÂÂ compatible = "ingenic,xburst-fpu1.0-mxu1.1";
> > +ÂÂÂÂÂÂÂÂÂÂÂ reg = <0>;
> > +ÂÂÂÂÂÂÂ };
> > +
> > +ÂÂÂÂÂÂÂ cpu1: cpu@1 {
> > +ÂÂÂÂÂÂÂÂÂÂÂ device_type = "cpu";
> > +ÂÂÂÂÂÂÂÂÂÂÂ compatible = "ingenic,xburst-fpu1.0-mxu1.1";
> > +ÂÂÂÂÂÂÂÂÂÂÂ reg = <1>;
> > +ÂÂÂÂÂÂÂ };
> > +ÂÂÂ };
> > +...
> > --
> > 2.11.0