Re: [PATCH] perf jvmti: remove redundant jitdump line table entries

From: Arnaldo Carvalho de Melo
Date: Wed May 27 2020 - 08:44:24 EST

On May 27, 2020 2:29:05 AM GMT-03:00, Nick Gasson <nick.gasson@xxxxxxx> wrote:
>On 05/26/20 19:55 PM, Jiri Olsa wrote:
>> On Fri, May 22, 2020 at 02:53:30PM +0800, Nick Gasson wrote:
>>> For each PC/BCI pair in the JVMTI compiler inlining record table,
>>> jitdump plugin emits debug line table entries for every source line
>>> the method preceding that BCI. Instead only emit one source line per
>>> PC/BCI pair. Reported by Ian Rogers. This reduces the .dump size for
>>> SPECjbb from ~230MB to ~40MB.
>>> Also fix an error in the DWARF line table state machine where
>>> are incorrectly offset by -0x40 (GEN_ELF_TEXT_OFFSET). This can be
>>> with `objdump -S` on the ELF files after perf inject.
>> hi,
>> I can't apply this on latest Arnaldo's perf/core:
>> patching file jvmti/libjvmti.c
>> Hunk #1 FAILED at 32.
>> Hunk #2 succeeded at 67 (offset -4 lines).
>> Hunk #3 FAILED at 85.
>> Hunk #4 succeeded at 114 (offset -7 lines).
>Sorry I based this on my earlier patch series below but I didn't
>that wasn't merged to perf/core yet. Could those patches be applied
>first? I believe Ian added a Reviewed-by for all three.

I'll check, thanks
- Arnaldo

Sent from my Android device with K-9 Mail. Please excuse my brevity.