Re: [PATCH 4.19 49/81] powerpc: Remove STRICT_KERNEL_RWX incompatibility with RELOCATABLE

[Pavel Machek]

On Tue 2020-05-26 20:53:24, Greg Kroah-Hartman wrote:
> From: Russell Currey <ruscur@xxxxxxxxxx>
> 
> [ Upstream commit c55d7b5e64265fdca45c85b639013e770bde2d0e ]
> 
> I have tested this with the Radix MMU and everything seems to work, and
> the previous patch for Hash seems to fix everything too.
> STRICT_KERNEL_RWX should still be disabled by default for now.
> 
> Please test STRICT_KERNEL_RWX + RELOCATABLE!

I don't believe this is suitable for -stable. Yes, it is needed for
the next patch, but doing the merge is right solution this time.

Best regards,
									Pavel


> +++ b/arch/powerpc/Kconfig
> @@ -139,7 +139,7 @@ config PPC
>  	select ARCH_HAS_MEMBARRIER_CALLBACKS
>  	select ARCH_HAS_SCALED_CPUTIME		if VIRT_CPU_ACCOUNTING_NATIVE
>  	select ARCH_HAS_SG_CHAIN
> -	select ARCH_HAS_STRICT_KERNEL_RWX	if ((PPC_BOOK3S_64 || PPC32) && !RELOCATABLE && !HIBERNATION)
> +	select ARCH_HAS_STRICT_KERNEL_RWX	if ((PPC_BOOK3S_64 || PPC32) && !HIBERNATION)
>  	select ARCH_HAS_TICK_BROADCAST		if GENERIC_CLOCKEVENTS_BROADCAST
>  	select ARCH_HAS_UACCESS_FLUSHCACHE	if PPC64
>  	select ARCH_HAS_UBSAN_SANITIZE_ALL

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

Attachment: signature.asc
Description: Digital signature