Re: [PATCH net-next] nexthop: Fix type of event_type in call_nexthop_notifiers
From: David Ahern
Date: Wed May 27 2020 - 09:50:40 EST
On 5/27/20 2:00 AM, Nathan Chancellor wrote:
> Clang warns:
>
> net/ipv4/nexthop.c:841:30: warning: implicit conversion from enumeration
> type 'enum nexthop_event_type' to different enumeration type 'enum
> fib_event_type' [-Wenum-conversion]
> call_nexthop_notifiers(net, NEXTHOP_EVENT_DEL, nh);
> ~~~~~~~~~~~~~~~~~~~~~~ ^~~~~~~~~~~~~~~~~
> 1 warning generated.
>
> Use the right type for event_type so that clang does not warn.
>
> Fixes: 8590ceedb701 ("nexthop: add support for notifiers")
> Link: https://github.com/ClangBuiltLinux/linux/issues/1038
> Signed-off-by: Nathan Chancellor <natechancellor@xxxxxxxxx>
> ---
> net/ipv4/nexthop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: David Ahern <dsahern@xxxxxxxxx>