Re: [PATCH] gpiolib: split character device into gpiolib-cdev

From: kbuild test robot
Date: Thu May 28 2020 - 00:08:23 EST

Hi Kent,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on v5.7-rc5]
[cannot apply to gpio/for-next linus/master linux/master v5.7-rc7 v5.7-rc6 next-20200526]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see]

base: 2ef96a5bb12be62ef75b5828c0aab838ebb29cb8
config: nios2-allmodconfig (attached as .config)
compiler: nios2-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
wget -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=nios2

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/gpio/gpiolib-cdev.c:1092:5: warning: no previous prototype for 'gpiolib_cdev_register' [-Wmissing-prototypes]
1092 | int gpiolib_cdev_register(struct gpio_device *gdev, dev_t devt)
| ^~~~~~~~~~~~~~~~~~~~~
>> drivers/gpio/gpiolib-cdev.c:1110:6: warning: no previous prototype for 'gpiolib_cdev_unregister' [-Wmissing-prototypes]
1110 | void gpiolib_cdev_unregister(struct gpio_device *gdev)
| ^~~~~~~~~~~~~~~~~~~~~~~

vim +/gpiolib_cdev_register +1092 drivers/gpio/gpiolib-cdev.c

> 1092 int gpiolib_cdev_register(struct gpio_device *gdev, dev_t devt)
1093 {
1094 int ret;
1096 cdev_init(&gdev->chrdev, &gpio_fileops);
1097 gdev->chrdev.owner = THIS_MODULE;
1098 gdev->dev.devt = MKDEV(MAJOR(devt), gdev->id);
1100 ret = cdev_device_add(&gdev->chrdev, &gdev->dev);
1101 if (ret)
1102 return ret;
1104 chip_dbg(gdev->chip, "added GPIO chardev (%d:%d)\n",
1105 MAJOR(devt), gdev->id);
1107 return 0;
1108 }
> 1110 void gpiolib_cdev_unregister(struct gpio_device *gdev)
1111 {
1112 cdev_device_del(&gdev->chrdev, &gdev->dev);
1113 }

0-DAY CI Kernel Test Service, Intel Corporation

Attachment: .config.gz
Description: application/gzip