Re: [PATCH] ASoC: AMD: Use mixer control to switch between DMICs

From: Agrawal, Akshu
Date: Thu May 28 2020 - 01:16:20 EST



On 5/27/2020 4:57 PM, Mark Brown wrote:
On Wed, May 27, 2020 at 07:10:16AM +0530, Akshu Agrawal wrote:

+ SOC_SINGLE_BOOL_EXT("Front Mic", 0, front_mic_get, front_mic_set),
This should probably be a mux with two labelled options, or if it's a
boolean control it should end in Switch. A mux definitely seems like a
better option though.

Actually it's a dmic switch, so will change it to boolean control named "DMIC switch". Front or rear mic might change with variants.

Thanks,

Akshu