Re: [PATCH] vfio/mdev: Fix reference count leak in add_mdev_supported_type.

[Cornelia Huck]

On Wed, 27 May 2020 21:01:09 -0500
wu000273@xxxxxxx wrote:

> From: Qiushi Wu <wu000273@xxxxxxx>
> 
> kobject_init_and_add() takes reference even when it fails.
> If this function returns an error, kobject_put() must be called to
> properly clean up the memory associated with the object. Thus,
> replace kfree() by kobject_put() to fix this issue. Previous
> commit "b8eb718348b8" fixed a similar problem.
> 
> Fixes: 7b96953bc640 ("vfio: Mediated device Core driver")
> Signed-off-by: Qiushi Wu <wu000273@xxxxxxx>
> ---
>  drivers/vfio/mdev/mdev_sysfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Cornelia Huck <cohuck@xxxxxxxxxx>