Re: [PATCH 1/1] s390/pci: Log new handle in clp_disable_fh()

From: Vasily Gorbik
Date: Thu May 28 2020 - 06:05:52 EST


On Thu, May 28, 2020 at 12:01:45PM +0200, Pierre Morel wrote:
>
> On 2020-05-28 11:08, Petr Tesarik wrote:
> > Hi all,
> >
> > just a gentle ping.
> >
> > If the current behaviour (logging the original handle) was intended,
> > then it was worth mentioning in the commit message for 17cdec960cf77,
> > which made the change, but since that's no longer an option, I'd be
> > happy with an explanation in email.
> >
> > Petr T
> >
> > On Fri, 22 May 2020 20:39:22 +0200
> > Petr Tesarik <ptesarik@xxxxxxxx> wrote:
> >
> > > After disabling a function, the original handle is logged instead of
> > > the disabled handle.
>
> Hi Petr,
>
> Sorry for the delay, no doubt, you are right, the fh in zpci_dbg is the old
> one and we should use the one in the zdev struct.
>
> Thanks,
> Pierre
>
> Reviewed-by: Pierre Morel <pmorel@xxxxxxxxxxxxx>

Applied, thanks