Re: [PATCH v4 2/2] gpio: add a reusable generic gpio_chip using regmap

From: Andy Shevchenko
Date: Thu May 28 2020 - 06:08:12 EST


On Thu, May 28, 2020 at 10:46:56AM +0200, Michael Walle wrote:
> Am 2020-05-28 10:37, schrieb Andy Shevchenko:
> > On Thu, May 28, 2020 at 7:11 AM Michael Walle <michael@xxxxxxxx> wrote:
> > > Am 2020-05-28 02:31, schrieb Pierre-Louis Bossart:
> >
> >
> > > I've send a v5 with that fix and your names property.
> >
> > Did you already?
>
> Yes, I forgot to add you :(
>
> > Because I have a question why we have gpio-regmap.h instead of
> > gpio/regmap.h ?
>
> No particular reason, I thought gpio/ was for low level gpio stuff (like
> the consumer.h, driver.h etc) or lets say - more integrated stuff.
>
> I don't have a strong opinion. I can send a v6 with that change, on
> short notice if the maintainers prefer that location.

I guess it's quite close to core and belongs to GPIO family of headers, I
definitely would like to see it there, but let's wait for Linus and Bart to
speak up.

--
With Best Regards,
Andy Shevchenko