Re: [v5] workqueue: Remove unnecessary kfree() call in rcu_free_wq()

From: Markus Elfring
Date: Thu May 28 2020 - 07:00:28 EST


>> Guys, the patch is wrong. The kfree is harmless when this is called
>> from destroy_workqueue() and required when it's called from
>> pwq_unbound_release_workfn(). Lai Jiangshan already explained this
>> already. Why are we still discussing this?
>
> Oops, missed that. Reverting.

Can it matter to use separate callback functions for these cases?
https://elixir.bootlin.com/linux/v5.7-rc7/C/ident/rcu_free_pwq

Regards,
Markus