Re: [PATCH v2 1/6] mtd: spi-nor: cadence-quadspi: Make driver independent of flash geometry

From: Tudor.Ambarus
Date: Thu May 28 2020 - 07:41:58 EST


On Tuesday, May 26, 2020 12:35:59 PM EEST Vignesh Raghavendra wrote:
> Drop configuration of Flash size, erase size and page size
> configuration. Flash size is needed only if using AHB decoder (BIT 23 of
> CONFIG_REG) which is not used by the driver.
> Erase size and page size are needed if IP is configured to send WREN
> automatically. But since SPI NOR layer takes care of sending WREN, there
> is no need to configure these fields either.
>
> Therefore drop these in preparation to move the driver to spi-mem
> framework where flash geometry is not visible to controller driver.
>
> Signed-off-by: Vignesh Raghavendra <vigneshr@xxxxxx>
> ---
> .../mtd/spi-nor/controllers/cadence-quadspi.c | 36 +------------------
> 1 file changed, 1 insertion(+), 35 deletions(-)

Reviewed-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxxxxx>