RE: [PATCH v2 1/3] scsi: ufs: remove max_t in ufs_get_device_desc

[Avri Altman]

> 
> From: Bean Huo <beanhuo@xxxxxxxxxx>
> 
> For the UFS device, the maximum descriptor size is 255, max_t called in
> ufs_get_device_desc() is useless.
> 
> Signed-off-by: Bean Huo <beanhuo@xxxxxxxxxx>
Acked-by: Avri Altman <avri.altman@xxxxxxx>

> ---
>  drivers/scsi/ufs/ufshcd.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index aca50ed39844..0f8c7e05df29 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -6881,8 +6881,7 @@ static int ufs_get_device_desc(struct ufs_hba *hba)
>         u8 *desc_buf;
>         struct ufs_dev_info *dev_info = &hba->dev_info;
> 
> -       buff_len = max_t(size_t, hba->desc_size.dev_desc,
> -                        QUERY_DESC_MAX_SIZE + 1);
> +       buff_len = QUERY_DESC_MAX_SIZE + 1;
So why the +1?
Originally it was used for the '\0' terminator, which is not needed anymore.