Re: [PATCH] sbp-target: add the missed kfree() in an error path
From: Chris Boot
Date: Thu May 28 2020 - 11:17:07 EST
On 28/05/2020 15:53, Bart Van Assche wrote:
> On 2020-05-28 03:20, Chuhong Yuan wrote:
>> sbp_fetch_command() forgets to call kfree() in an error path.
>> Add the missed call to fix it.
>
> Hi Chris,
>
> The changelog of the code under drivers/target/sbp makes we wonder
> whether this driver has ever had any other users than its original
> author. Do you agree with this? If so, do you want to keep this driver
> in the kernel tree?
Hi Bart,
I think you might be right. I also don't have much time to maintain it
these days and the hardware I had is long dead. It probably should be
removed for everyone's sanity.
Best regards,
Chris
--
Chris Boot
bootc@xxxxxxxxx