Re: [v5] workqueue: Remove unnecessary kfree() call in rcu_free_wq()

From: Markus Elfring
Date: Thu May 28 2020 - 11:25:44 EST


>> Still, the kfree(NULL) is harmless. But it is cleaner
>> to have the patch. But the changelog is wrong, even after
>> the lengthened debating, and English is not my mother tongue,
>> so I just looked on.
>
> We have tried to tell Markus not to advise people about commit messages

A few concerns were mentioned.


> but he doesn't listen.

I am still listening as usual.

I am offering constructive patch reviews for selected topics.


> He has discouraged some contributors. :/

There are the usual risks that additional views are occasionally not picked up
in positive ways.

Regards,
Markus