Re: [PATCH] clk: add api to get clk consummer from clk_hw
From: Jerome Brunet
Date: Thu May 28 2020 - 14:58:53 EST
On Wed 27 May 2020 at 22:07, Martin Blumenstingl <martin.blumenstingl@xxxxxxxxxxxxxx> wrote:
> Hi Jerome,
> On Tue, May 19, 2020 at 7:09 PM Jerome Brunet <jbrunet@xxxxxxxxxxxx> wrote:
>> + * Calls to this function must be balanced with calls clk_put()
>> + */
>> +struct clk *clk_hw_get_clk(struct clk_hw *hw)
> I haven't looked at it myself yet, but would it be hard to have a
> devm_ variant of this function as well?
Seems easy enough.
Stephen is this OK with you ?
I'm just wondering if this devm_ function should use the device pointer
embedded in the clk_hw structure or have it as an argument ?
The 1st option seems simpler but I'm not sure it is correct.
> a non-devm managed function would add boilerplate to the meson-mx-sdhc-mmc code
> also this may or may not simplify how to fetch the struct device
> pointer for this use-case.
> (that said, I only know about drivers for Amlogic related IP and there
> the devm_ variant can be used, but I don't know about other potential
> consumers of this new API)
> Thank you!