Re: [PATCH v3 00/14] mtd: spi-nor: add xSPI Octal DTR support

From: masonccyang
Date: Fri May 29 2020 - 01:27:14 EST



Hi Boris,

> >
> >
> > Summary of change log
> > v3:
> > Add support command sequences to change octal DTR mode and based on
> > part of Pratyush's patches set.
> >
> > v2:
> > Parse BFPT & xSPI table for Octal 8D-8D-8D mode parameters and enable
Octal
> > mode in spi_nor_late_init_params().
> > Using Macros in spi_nor_spimem_read_data, spi_nor_spimem_write_data
and
> > so on by Vignesh comments.
> >
> > v1:
> > Without parsing BFPT & xSPI profile 1.0 table and enter Octal 8D-8D-8D
> > mode directly in spi_nor_fixups hooks.
> >
> >
> > thnaks for your time and review.
> > best regards,
> > Mason
> >
> > --
> > Mason Yang (7):
> > mtd: spi-nor: sfdp: get octal mode maximum speed from BFPT
> > mtd: spi-nor: sfdp: parse xSPI Profile 1.0 table
> > mtd: spi-nor: sfdp: parse command sequences to change octal DTR mode
> > mtd: spi-nor: core: add configuration register 2 read & write
support
> > spi: mxic: patch for octal DTR mode support
> > mtd: spi-nor: core: execute command sequences to change octal DTR
mode
> > mtd: spi-nor: macronix: Add Octal 8D-8D-8D supports for Macronix
> > mx25uw51245g
> >
> > Pratyush Yadav (7):
> > spi: spi-mem: allow specifying whether an op is DTR or not
> > spi: spi-mem: allow specifying a command's extension
> > mtd: spi-nor: add support for DTR protocol
> > mtd: spi-nor: sfdp: prepare BFPT parsing for JESD216 rev D
> > mtd: spi-nor: sfdp: get command opcode extension type from BFPT
> > mtd: spi-nor: core: use dummy cycle and address width info from SFDP
> > mtd: spi-nor: core: enable octal DTR mode when possible
>
> Why are you doing that?! This series is being actively worked on by
> Pratyush, and all you gain by sending it on your own is more
> confusion. If you have patches on top of a series that's not been
> merged yet, mention the dependency in the cover letter, but don't
> resend patches that have already been sent and are being reviewed.

okay, much thank for your comments.
Will re-submit and mention the dependency in my cover letter.

Hi Pratyush,
Sorry if these patches make you uncomfortable.

>
> I think it's time you spend a bit of time learning about the submission
> process, because that's not the first mistake you do, and I'm pretty
> sure I already mentioned that in my previous reviews.

best regards,
Mason

CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information
and/or personal data, which is protected by applicable laws. Please be
reminded that duplication, disclosure, distribution, or use of this e-mail
(and/or its attachments) or any part thereof is prohibited. If you receive
this e-mail in error, please notify us immediately and delete this mail as
well as its attachment(s) from your system. In addition, please be
informed that collection, processing, and/or use of personal data is
prohibited unless expressly permitted by personal data protection laws.
Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================



============================================================================

CONFIDENTIALITY NOTE:

This e-mail and any attachments may contain confidential information and/or personal data, which is protected by applicable laws. Please be reminded that duplication, disclosure, distribution, or use of this e-mail (and/or its attachments) or any part thereof is prohibited. If you receive this e-mail in error, please notify us immediately and delete this mail as well as its attachment(s) from your system. In addition, please be informed that collection, processing, and/or use of personal data is prohibited unless expressly permitted by personal data protection laws. Thank you for your attention and cooperation.

Macronix International Co., Ltd.

=====================================================================