Re: [PATCH] net: ethernet: mtk-star-emac: remove unused variable

[Bartosz Golaszewski]

pt., 29 maj 2020 o 10:26 Bartosz Golaszewski <brgl@xxxxxxxx> napisaÅ(a):
>
> From: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
>
> The desc pointer is set but not used. Remove it.
>
> Reported-by: kbuild test robot <lkp@xxxxxxxxx>
> Fixes: 8c7bd5a454ff ("net: ethernet: mtk-star-emac: new driver")
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@xxxxxxxxxxxx>
> ---
>  drivers/net/ethernet/mediatek/mtk_star_emac.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/mediatek/mtk_star_emac.c b/drivers/net/ethernet/mediatek/mtk_star_emac.c
> index 8596ca0e60eb..7df35872c107 100644
> --- a/drivers/net/ethernet/mediatek/mtk_star_emac.c
> +++ b/drivers/net/ethernet/mediatek/mtk_star_emac.c
> @@ -746,15 +746,12 @@ mtk_star_ring_free_skbs(struct mtk_star_priv *priv, struct mtk_star_ring *ring,
>                                            struct mtk_star_ring_desc_data *))
>  {
>         struct mtk_star_ring_desc_data desc_data;
> -       struct mtk_star_ring_desc *desc;
>         int i;
>
>         for (i = 0; i < MTK_STAR_RING_NUM_DESCS; i++) {
>                 if (!ring->dma_addrs[i])
>                         continue;
>
> -               desc = &ring->descs[i];
> -
>                 desc_data.dma_addr = ring->dma_addrs[i];
>                 desc_data.skb = ring->skbs[i];
>
> --
> 2.26.1
>

Cr*p I forgot to tag it for net-next. David let me know if you want me
to resend it.

Bartosz