RE: [PATCH 0/3] misc: xilinx-sdfec: convert get_user_pages() --> pin_user_pages()

[Dragan Cvetic]

Hi John,

Thank you for the suggestion, please find my comment below: 

> -----Original Message-----
> From: John Hubbard <jhubbard@xxxxxxxxxx>
> Sent: Wednesday 27 May 2020 02:26
> To: LKML <linux-kernel@xxxxxxxxxxxxxxx>
> Cc: Souptick Joarder <jrdr.linux@xxxxxxxxx>; John Hubbard <jhubbard@xxxxxxxxxx>; Derek Kiernan <dkiernan@xxxxxxxxxx>; Dragan
> Cvetic <draganc@xxxxxxxxxx>; Arnd Bergmann <arnd@xxxxxxxx>; Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>; Michal Simek
> <michals@xxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> Subject: [PATCH 0/3] misc: xilinx-sdfec: convert get_user_pages() --> pin_user_pages()
> 
> Hi,
> 
> There are also a couple of tiny cleanup patches, just to fix up a few
> minor issues that I spotted while converting from get_user_pages_fast()
> to pin_user_pages_fast().
> 
> Note that I have only compile-tested these patches, although that does
> also include cross-compiling for a few other arches. Any run-time
> testing would be greatly appreciated!
> 
> Cc: Derek Kiernan <derek.kiernan@xxxxxxxxxx>
> Cc: Dragan Cvetic <dragan.cvetic@xxxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Michal Simek <michal.simek@xxxxxxxxxx>
> Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> 
> John Hubbard (3):
>   misc: xilinx-sdfec: improve get_user_pages_fast() error handling
>   misc: xilinx-sdfec: cleanup return value in xsdfec_table_write()
>   misc: xilinx-sdfec: convert get_user_pages() --> pin_user_pages()


Reviewed-by:
	Technically there is no problem in this patch, but as you said this should be tested.
	Currently due to Covid-19 I'm not able to access the HW and I cannot validate this suggestion.


> 
>  drivers/misc/xilinx_sdfec.c | 30 +++++++++++++++++-------------
>  1 file changed, 17 insertions(+), 13 deletions(-)
> 
> 
> base-commit: 9cb1fd0efd195590b828b9b865421ad345a4a145
> --
> 2.26.2