Re: [PATCH] edac: Fix reference count leak in edac_device_register_sysfs_main_kobj()

From: Borislav Petkov
Date: Fri May 29 2020 - 05:08:27 EST


On Fri, May 29, 2020 at 10:45:08AM +0200, Markus Elfring wrote:
> Would you like to indicate with such information (according to
> the topic ânet-sysfs: Fix reference count leak in rx|netdev_queue_add_kobjectâ)
> that your issue was detected also with the help of the kernel fuzzing
> tool âsyzkallerâ?

There's no need for any commt reference - there's text over
kobject_init_and_add() explaining what you need to do when that function
fails.

> How do you think about to add an imperative wording to the change description?

His commit message is fine.

> Will it be helpful to combine this update step together with
> âedac: Fix reference count leak in edac_pci_main_kobj_setupâ
> into a small patch series?

Just combine them into one patch.

Thx.

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette