Re: [PATCH v3 1/5] regulator: Allow regulators to verify enabled during enable()

From: Mark Brown
Date: Fri May 29 2020 - 06:50:43 EST

On Thu, May 28, 2020 at 06:37:43PM -0700, Bjorn Andersson wrote:
> On Thu 28 May 08:46 PDT 2020, Sumit Semwal wrote:

> > Some regulators might need to verify that they have indeed been enabled
> > after the enable() call is made and enable_time delay has passed.

> > _regulator_enable_delay(delay);

> My interpretation of "enable_time" (i.e. the value of delay) is that it
> denotes the maximum time it will take for the regulator to turn on, and


> the purpose of this patch is to be able to handle cases where we can
> poll the hardware to see if it completed earlier.

Is that it? From the changelog it sounded like this was a workaround
for broken hardware not an attempt at optimization.

> So I think you should flip the meaning of your two variables around,
> making "delay" the total time to sleep and the newly introduced
> "poll_enabled_time" the interval at which you check if the hardware
> finished early.


Attachment: signature.asc
Description: PGP signature