Re: [PATCHES] uaccess comedi compat
From: Al Viro
Date: Fri May 29 2020 - 10:16:12 EST
On Fri, May 29, 2020 at 11:48:51AM +0100, Ian Abbott wrote:
> > Al Viro (10):
> > comedi: move compat ioctl handling to native fops
> > comedi: get rid of indirection via translated_ioctl()
> > comedi: get rid of compat_alloc_user_space() mess in COMEDI_CHANINFO compat
> > comedi: get rid of compat_alloc_user_space() mess in COMEDI_RANGEINFO compat
> > comedi: get rid of compat_alloc_user_space() mess in COMEDI_INSN compat
> > comedi: get rid of compat_alloc_user_space() mess in COMEDI_INSNLIST compat
> > comedi: lift copy_from_user() into callers of __comedi_get_user_cmd()
> > comedi: do_cmdtest_ioctl(): lift copyin/copyout into the caller
> > comedi: do_cmd_ioctl(): lift copyin/copyout into the caller
> > comedi: get rid of compat_alloc_user_space() mess in COMEDI_CMD{,TEST} compat
>
> There is a bug in patch 05. Patch 10 doesn't seem to have been sent yet (I
> didn't receive it and I can't see it in the thread in the LKML archives).
> I've signed off on 01-04, 06-09.
#5 fixed, force-pushed to the same branch. As for s-o-b... are you sure that's
the header you have in mind? Normally it's for the chain of transmission...
Do you offer to take that series through comedi (or staging, or...) git tree?
In that case s-o-b would make sense and I'd be happy to have it taken off
my hands. Otherwise it probably should be Acked-by: or Reviewed-by: or
Read-through-and-managed-not-to-throw-up: - up to you...
> These should be Cc'd to Greg KH and to devel@xxxxxxxxxxxxxxxxxxxxx
FWIW, 10/10 seems to have been really lost; follows here: