Re: [PATCH v2 2/2] selftests/ftrace: Distinguish between hist and synthetic event checks

[Steven Rostedt]

On Fri, 29 May 2020 23:38:45 +0900
Masami Hiramatsu <mhiramat@xxxxxxxxxx> wrote:

> Hi Tom,
> 
> On Thu, 28 May 2020 14:32:38 -0500
> Tom Zanussi <zanussi@xxxxxxxxxx> wrote:
> 
> > With synthetic events now a separate config item as a result of
> > 'tracing: Move synthetic events to a separate file', tests that use
> > both need to explicitly check for hist trigger support rather than
> > relying on hist triggers to pull in synthetic events.
> > 
> > Add an additional hist trigger check to all the trigger tests that now
> > require it, otherwise they'll fail if synthetic events but not hist
> > triggers are enabled.  
> 
> OK, this looks good to me. And if you don't want to repeat it,
> you can also put the check function into the test.d/functions.
> 
> Acked-by: Masami Hiramatsu <mhiramat@xxxxxxxxxx>

Thanks Tom and Masami. I'm running tests on these now.

-- Steve