Re: [PATCH 2/2] nvmem: add ONIE NVMEM cells support

From: kbuild test robot
Date: Fri May 29 2020 - 17:21:46 EST

Hi Vadym,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on linus/master]
[also build test WARNING on linux/master v5.7-rc7 next-20200529]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see]

base: b0c3ba31be3e45a130e13b278cf3b90f69bda6f6
config: x86_64-randconfig-r024-20200529 (attached as .config)
compiler: clang version 11.0.0 ( 2d068e534f1671459e1b135852c1b3c10502e929)
reproduce (this is a W=1 build):
wget -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install x86_64 cross compiling tool for clang build
# apt-get install binutils-x86-64-linux-gnu
# save the attached .config to linux build tree
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All warnings (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/nvmem/onie-cells.c:56:57: warning: size argument in 'memcmp' call is a comparison [-Wmemsize-comparison]
if (memcmp(hdr->id, ONIE_NVMEM_HDR_ID, sizeof(hdr->id) != 0))
drivers/nvmem/onie-cells.c:56:6: note: did you mean to compare the result of 'memcmp' instead?
if (memcmp(hdr->id, ONIE_NVMEM_HDR_ID, sizeof(hdr->id) != 0))
^ ~
drivers/nvmem/onie-cells.c:56:41: note: explicitly cast the argument to size_t to silence this warning
if (memcmp(hdr->id, ONIE_NVMEM_HDR_ID, sizeof(hdr->id) != 0))
(size_t)( )
1 warning generated.

vim +/memcmp +56 drivers/nvmem/onie-cells.c

54 static bool onie_nvmem_hdr_is_valid(struct onie_nvmem_hdr *hdr)
55 {
> 56 if (memcmp(hdr->id, ONIE_NVMEM_HDR_ID, sizeof(hdr->id) != 0))
57 return false;
58 if (hdr->version != 0x1)
59 return false;
61 return true;
62 }

0-DAY CI Kernel Test Service, Intel Corporation

Attachment: .config.gz
Description: application/gzip