Re: [PATCH v1] auxdisplay: charlcd: Reuse hex_to_bin() instead of custom code

[Miguel Ojeda]

Hi Andy,

On Mon, May 18, 2020 at 9:36 PM Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>
> hex_to_bin() may be used to convert hexdecimal digit to its binary
> representation.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---

Looks fine to me and the logic is simpler for the `esc` increase too.
Thanks for the cleanup! Were you able to test it, by any chance? I
will queue it up for -rc1.

 (Sidenote: it would be nice if `git patch` allowed for a full-to-full
comparison for patches like this since the unified format is harder to
read; I couldn't find the option from a quick look...).

Cheers,
Miguel