Re: [PATCH v2 0/2] fix missing handling of __user in nommu's uaccess()

From: Greg Ungerer
Date: Fri May 29 2020 - 21:00:13 EST


Hi Luc,

On 30/5/20 5:02 am, Luc Van Oostenryck wrote:
I received a bug report for an unrelated patch when used with m68k-nommu.
It appears that the origin of the problem is that __get_user() and
__put_user() doesn't handle correctly __user. These 2 patches fix this.

Note: this is only minimaly tested but is quite straightforward and
since this only change __user annotation it will not change the
generated code.


Changes since v1:
* fix typo: s/plan/plain/
* appease checkpatch with better style: s/__force*/__force */
* avoid excessive line length caused by the added cast.

Luc Van Oostenryck (2):
m68k,nommu: add missing __user in uaccess' __ptr() macro
m68k,nommu: fix implicit cast from __user in __{get,put}_user_asm()

arch/m68k/include/asm/uaccess_no.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

Looks good, thanks for the fixup.
Applied to the m68knommu git tree, for-next branch.

Regards
Greg