Re: [PATCH] opp: avoid uninitialized-variable use
From: Arnd Bergmann
Date: Sat May 30 2020 - 08:41:18 EST
On Sat, May 30, 2020 at 11:21 AM Viresh Kumar <viresh.kumar@xxxxxxxxxx> wrote:
> On 29-05-20, 22:17, Arnd Bergmann wrote:
> > An uninitialized pointer is passed into another function but
> > --- a/drivers/opp/core.c
> > +++ b/drivers/opp/core.c
> > @@ -872,7 +872,7 @@ int dev_pm_opp_set_rate(struct device *dev, unsigned long target_freq)
> > goto put_opp_table;
> > }
> >
> > - ret = _set_opp_bw(opp_table, opp, dev, true);
> > + ret = _set_opp_bw(opp_table, NULL, dev, true);
> > if (ret)
> > return ret;
> >
>
> Not sure why people are still seeing this, I pushed a fix for this 2
> days back.
I was on next-20200528, which was the first version that was broken for me,
and I sent all my fixes after I had tested them. Since a lot of things
got broken
at once that day, it took me until the end of 20200529 to get it all tested
properly and then send them out.
Arnd