Re: [PATCH v4 4/4] kdb: Switch to use safer dbg_io_ops over console APIs

[kbuild test robot]

Hi Sumit,

I love your patch! Yet something to improve:

[auto build test ERROR on tty/tty-testing]
[also build test ERROR on usb/usb-testing v5.7-rc7 next-20200529]
[cannot apply to kgdb/kgdb-next]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Sumit-Garg/kdb-Improve-console-handling/20200531-075431
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing
config: x86_64-allyesconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 2388a096e7865c043e83ece4e26654bd3d1a20d5)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # install x86_64 cross compiling tool for clang build
        # apt-get install binutils-x86-64-linux-gnu
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kbuild test robot <lkp@xxxxxxxxx>

All errors (new ones prefixed by >>, old ones prefixed by <<):

>> drivers/usb/early/ehci-dbgp.c:1062:24: error: assigning to 'struct console *' from incompatible type 'struct console'; take the address with &
kgdbdbgp_io_ops.cons = early_dbgp_console;
^ ~~~~~~~~~~~~~~~~~~
&
1 error generated.

vim +1062 drivers/usb/early/ehci-dbgp.c

  1046	
  1047	static int __init kgdbdbgp_parse_config(char *str)
  1048	{
  1049		char *ptr;
  1050	
  1051		if (!ehci_debug) {
  1052			if (early_dbgp_init(str))
  1053				return -1;
  1054		}
  1055		ptr = strchr(str, ',');
  1056		if (ptr) {
  1057			ptr++;
  1058			kgdbdbgp_wait_time = simple_strtoul(ptr, &ptr, 10);
  1059		}
  1060		kgdb_register_io_module(&kgdbdbgp_io_ops);
  1061		if (early_dbgp_console.index != -1)
> 1062			kgdbdbgp_io_ops.cons = early_dbgp_console;
  1063	
  1064		return 0;
  1065	}
  1066	early_param("kgdbdbgp", kgdbdbgp_parse_config);
  1067	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@xxxxxxxxxxxx

Attachment: .config.gz
Description: application/gzip