Re: [PATCH] sh: Implement __get_user_u64() required for 64-bit get_user()

[John Paul Adrian Glaubitz]

On 5/31/20 11:54 AM, John Paul Adrian Glaubitz wrote:
> Hi Geert!
> 
> On 5/31/20 11:52 AM, Geert Uytterhoeven wrote:
>> As this is the 64-bit variant, I think this single move should be
>> replaced by a double move:
>>
>>        "mov  #0,%R1\n\t" \
>>        "mov  #0,%S1\n\t" \
>>
>> Same for the big endian version below.
>>
>> Disclaimer: uncompiled, untested, no SH assembler expert.
> 
> Right, this makes sense. I'll send a new patch shortly.

Hmm, this change is not the case for __put_user_asm() vs. __put_user_u64().

But I have to admit, I don't know what the part below "3:\n\t" is for.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@xxxxxxxxxx
`. `'   Freie Universitaet Berlin - glaubitz@xxxxxxxxxxxxxxxxxxx
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913