Re: [PATCH v3 07/18] nitro_enclaves: Init misc device providing the ioctl interface

From: Benjamin Herrenschmidt
Date: Sun May 31 2020 - 23:04:44 EST

On Thu, 2020-05-28 at 15:12 +0200, Greg KH wrote:
> So at runtime, after all is booted and up and going, you just ripped
> cores out from under someone's feet? :)
> And the code really handles writing to that value while the module is
> already loaded and up and running? At a quick glance, it didn't seem
> like it would handle that very well as it only is checked at ne_init()
> time.
> Or am I missing something?
> Anyway, yes, if you can dynamically do this at runtime, that's great,
> but it feels ackward to me to rely on one configuration thing as a
> module parameter, and everything else through the ioctl interface.
> Unification would seem to be a good thing, right?

I personally still prefer a sysfs file :) I really don't like module
parameters as a way to do such things.