Re: [PATCH v3] i2c: imx-lpi2c: Fix runtime PM imbalance in lpi2c_imx_master_enable()

From: Markus Elfring
Date: Mon Jun 01 2020 - 02:42:41 EST


> pm_runtime_get_sync() increments the runtime PM usage counter even
> the call returns an error code. Thus a corresponding decrement is
> needed on the error handling path to keep the counter balanced.
>
> Fix this by adding the missed function call.

How do you think about a wording variant like the following?

Change description:
The PM runtime usage counter is incremented even if a call of
the function âpm_runtime_get_syncâ failed. Thus decrement it also
in an error case so that the reference counting is kept consistent.


Regards,
Markus