Re: [PATCH] power: supply: bq24190_charger.c: call pm_runtime_put in pm_runtime_get_sync failed case

From: Markus Elfring
Date: Mon Jun 01 2020 - 04:03:28 EST


> Even in failed case of pm_runtime_get_sync, the usage_count
> is incremented. In order to keep the usage_count with correct
> value call pm_runtime_put_autosuspend.

* I find the word âusage_countâ questionable in this change description.

* Will the tag âFixesâ become relevant for the commit message?

* Can an other label be more helpful than âoutâ?

* Would you like to take another look at a related update suggestion
like âpower: supply: bq24190_charger: Fix runtime PM imbalance on errorâ?
https://lore.kernel.org/linux-pm/20200525110540.6949-1-dinghao.liu@xxxxxxxxxx/
https://lore.kernel.org/patchwork/patch/1246783/

Regards,
Markus