Re: [tip: sched/core] sched: Fix smp_call_function_single_async() usage for ILB
From: Frederic Weisbecker
Date: Mon Jun 01 2020 - 07:40:14 EST
On Mon, Jun 01, 2020 at 09:52:21AM -0000, tip-bot2 for Peter Zijlstra wrote:
> The following commit has been merged into the sched/core branch of tip:
> Commit-ID: 19a1f5ec699954d21be10f74ff71c2a7079e99ad
> Gitweb: https://git.kernel.org/tip/19a1f5ec699954d21be10f74ff71c2a7079e99ad
> Author: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> AuthorDate: Tue, 26 May 2020 18:10:58 +02:00
> Committer: Ingo Molnar <mingo@xxxxxxxxxx>
> CommitterDate: Thu, 28 May 2020 10:54:15 +02:00
> sched: Fix smp_call_function_single_async() usage for ILB
> The recent commit: 90b5363acd47 ("sched: Clean up scheduler_ipi()")
> got smp_call_function_single_async() subtly wrong. Even though it will
> return -EBUSY when trying to re-use a csd, that condition is not
> atomic and still requires external serialization.
> The change in kick_ilb() got this wrong.
> While on first reading kick_ilb() has an atomic test-and-set that
> appears to serialize the use, the matching 'release' is not in the
> right place to actually guarantee this serialization.
> Rework the nohz_idle_balance() trigger so that the release is in the
> IPI callback and thus guarantees the required serialization for the
> Fixes: 90b5363acd47 ("sched: Clean up scheduler_ipi()")
> Reported-by: Qian Cai <cai@xxxxxx>
> Signed-off-by: Peter Zijlstra (Intel) <peterz@xxxxxxxxxxxxx>
> Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
> Reviewed-by: Frederic Weisbecker <frederic@xxxxxxxxxx>
> Cc: mgorman@xxxxxxxxxxxxxxxxxxx
> Link: https://lore.kernel.org/r/20200526161907.778543557@xxxxxxxxxxxxx
Many patches in the series lack some Reviewed-by tags.