RE: [Intel-wired-lan] [PATCH] [net-next] e1000e: fix unused-function warning

[Brown, Aaron F]

> From: Intel-wired-lan <intel-wired-lan-bounces@xxxxxxxxxx> On Behalf Of Arnd
> Bergmann
> Sent: Wednesday, May 27, 2020 6:47 AM
> To: Kirsher, Jeffrey T <jeffrey.t.kirsher@xxxxxxxxx>; David S. Miller
> <davem@xxxxxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Lifshits, Vitaly
> <vitaly.lifshits@xxxxxxxxx>
> Cc: Arnd Bergmann <arnd@xxxxxxxx>; Konstantin Khlebnikov
> <khlebnikov@xxxxxxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx; Wysocki, Rafael J
> <rafael.j.wysocki@xxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; intel-wired-
> lan@xxxxxxxxxxxxxxxx; Alexander Duyck <alexander.h.duyck@xxxxxxxxxxxxxxx>
> Subject: [Intel-wired-lan] [PATCH] [net-next] e1000e: fix unused-function
> warning
> 
> The CONFIG_PM_SLEEP #ifdef checks in this file are inconsistent,
> leading to a warning about sometimes unused function:
> 
> drivers/net/ethernet/intel/e1000e/netdev.c:137:13: error: unused function
> 'e1000e_check_me' [-Werror,-Wunused-function]
> 
> Rather than adding more #ifdefs, just remove them completely
> and mark the PM functions as __maybe_unused to let the compiler
> work it out on it own.
> 
> Fixes: e086ba2fccda ("e1000e: disable s0ix entry and exit flows for ME systems")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
>  drivers/net/ethernet/intel/e1000e/netdev.c | 16 +++++-----------
>  1 file changed, 5 insertions(+), 11 deletions(-)
> 
Tested-by: Aaron Brown <aaron.f.brown@xxxxxxxxx>