Re: [PATCH v2 05/10] x86/percpu: Remove "e" constraint from XADD

[Nick Desaulniers]

On Sat, May 30, 2020 at 3:11 PM Brian Gerst <brgerst@xxxxxxxxx> wrote:
>
> The "e" constraint represents a constant, but the XADD instruction doesn't
> accept immediate operands.
>
> Signed-off-by: Brian Gerst <brgerst@xxxxxxxxx>

Yep, as we discussed in v1.
Reviewed-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>

> ---
>  arch/x86/include/asm/percpu.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/include/asm/percpu.h b/arch/x86/include/asm/percpu.h
> index 2a24f3c795eb..9bb5440d98d3 100644
> --- a/arch/x86/include/asm/percpu.h
> +++ b/arch/x86/include/asm/percpu.h
> @@ -220,7 +220,7 @@ do {                                                                        \
>                 break;                                                  \
>         case 8:                                                         \
>                 asm qual ("xaddq %0, "__percpu_arg(1)                   \
> -                           : "+re" (paro_ret__), "+m" (var)            \
> +                           : "+r" (paro_ret__), "+m" (var)             \
>                             : : "memory");                              \
>                 break;                                                  \
>         default: __bad_percpu_size();                                   \
> --
> 2.25.4
>


-- 
Thanks,
~Nick Desaulniers