Re: [PATCH] bpf: Change kvfree to kfree in generic_map_lookup_batch()

From: Song Liu
Date: Mon Jun 01 2020 - 16:18:10 EST


On Mon, Jun 1, 2020 at 9:29 AM Denis Efremov <efremov@xxxxxxxxx> wrote:
>
> buf_prevkey in generic_map_lookup_batch() is allocated with
> kmalloc(). It's safe to free it with kfree().
>
> Signed-off-by: Denis Efremov <efremov@xxxxxxxxx>

Please add prefix "PATCH bpf" or "PATCH bpf-next" to indicate which
tree this should
apply to. This one looks more like for bpf-next, as current code still
works. For patches
to bpf-next, we should wait after the merge window.

Also, maybe add:

Fixes: cb4d03ab499d ("bpf: Add generic support for lookup batch op")

Acked-by: Song Liu <songliubraving@xxxxxx>

Thanks,
Song