RE: [PATCH 4.4 00/48] 4.4.226-rc1 review

[Chris Paterson]

Hi Greg,

> From: stable-owner@xxxxxxxxxxxxxxx <stable-owner@xxxxxxxxxxxxxxx> On
> Behalf Of Greg Kroah-Hartman
> Sent: 01 June 2020 18:53
> 
> This is the start of the stable review cycle for the 4.4.226 release.
> There are 48 patches in this series, all will be posted as a response
> to this one.  If anyone has any issues with these being applied, please
> let me know.

I'm seeing some issues with Linux 4.4.226-rc1 (dc230329b026).

We have 4 configurations that fail, 2x Armv7 and 2x x86, whilst building the modules.

Error message:
  ERROR: "pptp_msg_name" [net/netfilter/nf_conntrack_pptp.ko] undefined!
  ERROR: "pptp_msg_name" [net/ipv4/netfilter/nf_nat_pptp.ko] undefined!

Relevant patches are:
  69969e0f7e37 ("netfilter: nf_conntrack_pptp: prevent buffer overflows in debug code")
  3441cc75e4d1 ("netfilter: nf_conntrack_pptp: fix compilation warning with W=1 build")

I haven't had a chance to dig deeper yet but will do in the morning.

Build/test pipeline/logs: https://gitlab.com/cip-project/cip-testing/linux-stable-rc-ci/pipelines/151700917
GitLab CI pipeline: https://gitlab.com/cip-project/cip-testing/linux-cip-pipelines/-/blob/master/trees/linux-4.4.y.yml
Relevant LAVA jobs: https://lava.ciplatform.org/scheduler/alljobs?length=25&search=dc2303#table

Kind regards, Chris

> 
> Responses should be made by Wed, 03 Jun 2020 17:38:19 +0000.
> Anything received after that time might be too late.
> 
> The whole patch series can be found in one patch at:
> 	https://www.kernel.org/pub/linux/kernel/v4.x/stable-review/patch-
> 4.4.226-rc1.gz
> or in the git tree and branch at:
> 	git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
> linux-4.4.y
> and the diffstat can be found below.
> 
> thanks,
> 
> greg k-h
> 
> -------------
> Pseudo-Shortlog of commits:
> 
> Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>     Linux 4.4.226-rc1
> 
> Ben Hutchings <ben.hutchings@xxxxxxxxxxxxxxx>
>     drm/msm: Fix possible null dereference on failure of get_pages()
> 
> Guoqing Jiang <gqjiang@xxxxxxxx>
>     sc16is7xx: move label 'err_spi' to correct section
> 
> Michal Marek <mmarek@xxxxxxxx>
>     asm-prototypes: Clear any CPP defines before declaring the functions
> 
> Liviu Dudau <liviu@xxxxxxxxxxx>
>     mm/vmalloc.c: don't dereference possible NULL pointer in __vunmap()
> 
> Roopa Prabhu <roopa@xxxxxxxxxxxxxxxxxxx>
>     net: rtnl_configure_link: fix dev flags changes arg to __dev_notify_flags
> 
> Sudip Mukherjee <sudip@xxxxxxxxxxxxxxx>
>     mac80211: fix memory leak
> 
> Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
>     usb: renesas_usbhs: gadget: fix spin_lock_init() for &uep->lock
> 
> Thomas Gleixner <tglx@xxxxxxxxxxxxx>
>     genirq/generic_pending: Do not lose pending affinity update
> 
> Matt Roper <matthew.d.roper@xxxxxxxxx>
>     drm/fb-helper: Use proper plane mask for fb cleanup
> 
> Konstantin Khlebnikov <khlebnikov@xxxxxxxxxxxxxx>
>     mm: remove VM_BUG_ON(PageSlab()) from page_mapcount()
> 
> Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
>     netfilter: nf_conntrack_pptp: fix compilation warning with W=1 build
> 
> Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
>     Revert "Input: i8042 - add ThinkPad S230u to i8042 nomux list"
> 
> Qiushi Wu <wu000273@xxxxxxx>
>     bonding: Fix reference count leak in bond_sysfs_slave_add.
> 
> Qiushi Wu <wu000273@xxxxxxx>
>     qlcnic: fix missing release in qlcnic_83xx_interrupt_test.
> 
> Pablo Neira Ayuso <pablo@xxxxxxxxxxxxx>
>     netfilter: nf_conntrack_pptp: prevent buffer overflows in debug code
> 
> Phil Sutter <phil@xxxxxx>
>     netfilter: ipset: Fix subcounter update skip
> 
> Michael Braun <michael-dev@xxxxxxxxxxxxx>
>     netfilter: nft_reject_bridge: enable reject with bridge vlan
> 
> Xin Long <lucien.xin@xxxxxxxxx>
>     ip_vti: receive ipip packet by calling ip_tunnel_rcv
> 
> Jeremy Sowden <jeremy@xxxxxxxxxx>
>     vti4: eliminated some duplicate code.
> 
> Xin Long <lucien.xin@xxxxxxxxx>
>     xfrm: fix a NULL-ptr deref in xfrm_local_error
> 
> Xin Long <lucien.xin@xxxxxxxxx>
>     xfrm: fix a warning in xfrm_policy_insert_list
> 
> Xin Long <lucien.xin@xxxxxxxxx>
>     xfrm: allow to accept packets with ipv6 NEXTHDR_HOP in xfrm_input
> 
> Alexander Dahl <post@xxxxxxxxxxx>
>     x86/dma: Fix max PFN arithmetic overflow on 32 bit systems
> 
> Helge Deller <deller@xxxxxx>
>     parisc: Fix kernel panic in mem_init()
> 
> Qiushi Wu <wu000273@xxxxxxx>
>     iommu: Fix reference count leak in iommu_group_alloc.
> 
> Arnd Bergmann <arnd@xxxxxxxx>
>     include/asm-generic/topology.h: guard cpumask_of_node() macro argument
> 
> Alexander Potapenko <glider@xxxxxxxxxx>
>     fs/binfmt_elf.c: allocate initialized memory in fill_thread_core_info()
> 
> Eric W. Biederman <ebiederm@xxxxxxxxxxxx>
>     exec: Always set cap_ambient in cap_bprm_set_creds
> 
> Chris Chiu <chiu@xxxxxxxxxxxx>
>     ALSA: usb-audio: mixer: volume quirk for ESS Technology Asus USB DAC
> 
> Changming Liu <liu.changm@xxxxxxxxxxxxxxxx>
>     ALSA: hwdep: fix a left shifting 1 by 31 UB bug
> 
> Kaike Wan <kaike.wan@xxxxxxxxx>
>     IB/qib: Call kobject_put() when kobject_init_and_add() fails
> 
> Kevin Locke <kevin@xxxxxxxxxxxxxxx>
>     Input: i8042 - add ThinkPad S230u to i8042 reset list
> 
> Åukasz Patron <priv.luk@xxxxxxxxx>
>     Input: xpad - add custom init packet for Xbox One S controllers
> 
> Brendan Shanks <bshanks@xxxxxxxxxxxxxxx>
>     Input: evdev - call input_flush_device() on release(), not flush()
> 
> Kevin Locke <kevin@xxxxxxxxxxxxxxx>
>     Input: i8042 - add ThinkPad S230u to i8042 nomux list
> 
> James Hilliard <james.hilliard1@xxxxxxxxx>
>     Input: usbtouchscreen - add support for BonXeon TP
> 
> Steve French <stfrench@xxxxxxxxxxxxx>
>     cifs: Fix null pointer check in cifs_read
> 
> Masahiro Yamada <masahiroy@xxxxxxxxxx>
>     usb: gadget: legacy: fix redundant initialization warnings
> 
> Lei Xue <carmark.dlut@xxxxxxxxx>
>     cachefiles: Fix race between read_waiter and read_copier involving op-
> >to_do
> 
> Bob Peterson <rpeterso@xxxxxxxxxx>
>     gfs2: don't call quota_unhold if quotas are not locked
> 
> Kalderon, Michal <Michal.Kalderon@xxxxxxxxxx>
>     IB/cma: Fix reference count leak when no ipv4 addresses are set
> 
> Dmitry V. Levin <ldv@xxxxxxxxxxxx>
>     uapi: fix linux/if_pppol2tp.h userspace compilation errors
> 
> Qiushi Wu <wu000273@xxxxxxx>
>     net/mlx4_core: fix a memory leak bug.
> 
> Qiushi Wu <wu000273@xxxxxxx>
>     net: sun: fix missing release regions in cas_init_one().
> 
> Moshe Shemesh <moshe@xxxxxxxxxxxx>
>     net/mlx5: Add command entry handling completion
> 
> Jere LeppÃnen <jere.leppanen@xxxxxxxxx>
>     sctp: Start shutdown on association restart if in SHUTDOWN-SENT state and
> socket is closed
> 
> Yuqi Jin <jinyuqi@xxxxxxxxxx>
>     net: revert "net: get rid of an signed integer overflow in ip_idents_reserve()"
> 
> Eric Dumazet <edumazet@xxxxxxxxxx>
>     ax25: fix setsockopt(SO_BINDTODEVICE)
> 
> 
> -------------
> 
> Diffstat:
> 
>  Makefile                                           |  4 +-
>  arch/parisc/mm/init.c                              |  2 +-
>  arch/x86/include/asm/dma.h                         |  2 +-
>  drivers/gpu/drm/drm_fb_helper.c                    |  2 +-
>  drivers/gpu/drm/msm/msm_gem.c                      | 20 +++---
>  drivers/infiniband/hw/qib/qib_sysfs.c              |  9 +--
>  drivers/input/evdev.c                              | 19 ++----
>  drivers/input/joystick/xpad.c                      | 12 ++++
>  drivers/input/serio/i8042-x86ia64io.h              |  7 ++
>  drivers/input/touchscreen/usbtouchscreen.c         |  1 +
>  drivers/iommu/iommu.c                              |  2 +-
>  drivers/net/bonding/bond_sysfs_slave.c             |  4 +-
>  drivers/net/ethernet/mellanox/mlx4/fw.c            |  2 +-
>  drivers/net/ethernet/mellanox/mlx5/core/cmd.c      | 15 +++++
>  .../net/ethernet/qlogic/qlcnic/qlcnic_83xx_hw.c    |  4 +-
>  drivers/net/ethernet/sun/cassini.c                 |  3 +-
>  drivers/tty/serial/sc16is7xx.c                     |  2 +
>  drivers/usb/gadget/legacy/inode.c                  |  3 +-
>  drivers/usb/renesas_usbhs/mod_gadget.c             |  2 +-
>  fs/binfmt_elf.c                                    |  2 +-
>  fs/cachefiles/rdwr.c                               |  2 +-
>  fs/cifs/file.c                                     |  2 +-
>  fs/gfs2/quota.c                                    |  3 +-
>  include/asm-generic/asm-prototypes.h               |  6 ++
>  include/asm-generic/topology.h                     |  2 +-
>  include/linux/mlx5/driver.h                        |  1 +
>  include/linux/mm.h                                 |  1 -
>  include/linux/netfilter/nf_conntrack_pptp.h        |  2 +-
>  include/rdma/ib_addr.h                             |  6 +-
>  include/uapi/linux/l2tp.h                          |  7 +-
>  kernel/irq/migration.c                             | 26 ++++++--
>  mm/vmalloc.c                                       |  2 +-
>  net/ax25/af_ax25.c                                 |  6 +-
>  net/bridge/netfilter/nft_reject_bridge.c           |  6 ++
>  net/core/rtnetlink.c                               |  2 +-
>  net/ipv4/ip_vti.c                                  | 75 ++++++++++++----------
>  net/ipv4/netfilter/nf_nat_pptp.c                   |  7 +-
>  net/ipv4/route.c                                   | 14 ++--
>  net/mac80211/sta_info.c                            |  1 +
>  net/netfilter/ipset/ip_set_list_set.c              |  2 +-
>  net/netfilter/nf_conntrack_pptp.c                  | 62 ++++++++++--------
>  net/sctp/sm_statefuns.c                            |  9 +--
>  net/xfrm/xfrm_input.c                              |  2 +-
>  net/xfrm/xfrm_output.c                             |  3 +-
>  net/xfrm/xfrm_policy.c                             |  7 +-
>  security/commoncap.c                               |  1 +
>  sound/core/hwdep.c                                 |  4 +-
>  sound/usb/mixer.c                                  |  8 +++
>  48 files changed, 229 insertions(+), 157 deletions(-)
>